This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
*: refactor subtask management and communication model #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
/run-all-tests |
/run-all-tests |
1 similar comment
/run-all-tests |
amyangfei
reviewed
May 20, 2019
dm/worker/log.go
Outdated
for { | ||
select { | ||
case <-ctx.Done(): | ||
log.Infof("[task log gc] goroutine exist!") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
log.Infof("[task log gc] goroutine exist!") | |
log.Info("[task log gc] goroutine exits!") |
/run-all-tests |
3 similar comments
/run-all-tests |
/run-all-tests |
/run-all-tests |
amyangfei
reviewed
May 20, 2019
/run-all-tests |
2 similar comments
/run-all-tests |
/run-all-tests |
/run-all-tests |
2 similar comments
/run-all-tests |
/run-all-tests |
csuzhangxc
reviewed
May 21, 2019
…to ian/refine-task
csuzhangxc
reviewed
May 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
csuzhangxc
added
status/LGT1
One reviewer already commented LGTM
and removed
status/PTAL
This PR is ready for review. Add this label back after committing new changes
labels
May 21, 2019
amyangfei
approved these changes
May 21, 2019
amyangfei
added
status/LGT2
Two reviewers already commented LGTM, ready for merge
and removed
status/LGT1
One reviewer already commented LGTM
labels
May 21, 2019
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
priority/normal
Minor change, requires approval from ≥1 primary reviewer
status/LGT2
Two reviewers already commented LGTM, ready for merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The
subtask state machine
andworker controller
mechanisms are not ideal now.Users use direct interaction to manipulate tasks, like user issue a create task request and the request fails, dm-worker wouldn't leave any information about it. the implementation is not conducive to debugging and make restoring tasks more difficult when dm-worker restarts. ref #77
What is changed and how it works?
task meta
andtask operation log
in ittask operation log
as a queue-like object, providing operationworker/handleTask
would apply these logs in order and mark it's resultwaitOperationOk
function for DM-server to make the asynchronous request be asynchronoussubtask state machine
Run
,Close
operations and make them reentrantI try to keep the original code of subtask.go and worker.go, and we will further simplify them while improve the test coverage.
In fact because the code is too much, I think it's better to issue first edition firstly. Don't worry, most of them are unit test.
Some review concerns
pause
andresume
function, it may affect some mechanisms likeonline ddl
Check List
Tests
Code changes
Side effects